Add PQC base system test by marcushines · Pull Request #5442 · openconfig/featureprofiles

marcushines · 2026-05-11T18:09:39Z

No description provided.

gemini-code-assist · 2026-05-11T18:09:48Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a suite of system-level tests designed to ensure that the device under test (DUT) correctly handles and supports Post-Quantum Cryptography (PQC) protocols. By utilizing a custom gRPC dialer with specific TLS curve preferences, the tests verify that secure connections can be established across various management and control plane interfaces.

Highlights

New PQC System Tests: Added a new test suite to validate Post-Quantum Cryptography (PQC) support across multiple network protocols including gNMI, gNOI, gNSI, gRIBI, and P4RT.
Custom TLS Configuration: Implemented a custom TLS dialer that enables the X25519Kyber768Draft00 key exchange mechanism to verify PQC handshake capabilities on the DUT.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

OpenConfigBot · 2026-05-11T18:10:05Z

Pull Request Functional Test Report for #5442 / `1cd8768`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		System-1.2: System g protocol test
Cisco 8000E		System-1.2: System g protocol test
Cisco XRd		System-1.2: System g protocol test
Juniper ncPTX		System-1.2: System g protocol test
Nokia SR Linux		System-1.2: System g protocol test
Openconfig Lemming		System-1.2: System g protocol test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		System-1.2: System g protocol test
Cisco 8808		System-1.2: System g protocol test
Juniper PTX10008		System-1.2: System g protocol test
Nokia 7250 IXR-10e		System-1.2: System g protocol test

Help

gemini-code-assist

Code Review

This pull request adds a new test file to verify Post-Quantum Cryptography (PQC) protocol support for gNMI, gNOI, gNSI, gRIBI, and P4RT services. The reviewer provided several improvement opportunities, including adhering to the repository style guide by implementing TestMain and setupEnvironment, simplifying the logic for handling non-standard gRPC ports, and replacing deprecated gRPC functions. There is also a recommendation to use t.Fatalf for better error handling in the gNSI test.

mihirpitale-googler

lgtm

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…update PQC protocol test to use grpc.NewClient.

robshakir · 2026-05-14T15:07:44Z

+| service-1.6 | gNMI PQC client   | gNMI Get works  |
+| service-1.7 | gNOI PQC client   | gNOI system Time works |
+| service-1.8 | gNSI PQC client   | gNSI authz Get works |
+| service-1.9 | gRIBI PQC client   | gRIBI Get works |
+| service-1.10 | p4rt PQC client   | P4RT Capabilities works |


For the description here, can we call out that these are specifically for PQC-algorithms or just differentiate them somehow from the ones that above?

robshakir · 2026-05-14T15:12:23Z

 | service-1.3 | gNSI client  | gNSI authz Get works |
 | service-1.4 | gRIBI client | gRIBI Get works |
 | service-1.5 | p4rt client  | P4RT Capabilities works |
+| service-1.6 | gNMI PQC client   | gNMI Get works  |


Can you add these to the testregistry.textproto at the root of the repo please?

robshakir · 2026-05-14T15:12:43Z


 ## OpenConfig Path and RPC Coverage

+## OpenConfig Path and RPC Coverage


Do we need this heading to be repeated?

robshakir · 2026-05-14T15:13:41Z

+| service-1.8 | gNSI PQC client   | gNSI authz Get works |
+| service-1.9 | gRIBI PQC client   | gRIBI Get works |
+| service-1.10 | p4rt PQC client   | P4RT Capabilities works |



It'd be useful to have some verbiage in the README that describes what the PQC tests do differently to the base tests.

robshakir · 2026-05-14T15:18:36Z

+	// Custom TLS config for PQC
+	tlsConfig := &tls.Config{
+		InsecureSkipVerify: true,
+		CurvePreferences:   []tls.CurveID{tls.X25519MLKEM768, tls.X25519, tls.CurveP256},


Did you consider just adding a parameter to the existing dialConn in system_g_protocol_test.go that takes the CurvePreferences or the tls.Config so that we don't duplicate the whole fn?

If you did this, you could probably make it such that you just have a table-driven test for each of the existing TestXXX functions with the different parameters.

Add PQC base system test

e25e366

marcushines requested a review from a team as a code owner May 11, 2026 18:09

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

marcushines and others added 3 commits May 11, 2026 13:59

Merge branch 'main' into hines1

cf0b97d

Add test cases to readme

cc39203

Merge remote-tracking branch 'refs/remotes/origin/hines1' into hines1

a177d02

mihirpitale-googler approved these changes May 11, 2026

View reviewed changes

marcushines and others added 3 commits May 11, 2026 14:36

Apply suggestions from code review

3890a55

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

feat: add gNOI Debug test plan, extend bootz test documentation, and …

c4b895f

…update PQC protocol test to use grpc.NewClient.

Merge remote-tracking branch 'refs/remotes/origin/hines1' into hines1

9654d69

marcushines force-pushed the hines1 branch 2 times, most recently from 02bc85e to 8d86dc1 Compare May 12, 2026 14:32

update json

fe86137

marcushines force-pushed the hines1 branch from 8d86dc1 to fe86137 Compare May 12, 2026 14:35

marcushines and others added 6 commits May 12, 2026 16:26

update json

7ec19d8

update json

a67eac8

fix datetime

bf7f042

remove ctx

46b253d

remove time

7e5b676

Merge branch 'main' into hines1

7075cd9

brianneville reviewed May 13, 2026

View reviewed changes

Comment thread feature/system/system_base_test/tests/system_g_protocol_test/system_pqc_protocol_test.go Outdated

use go1.25 constant

1cd8768

robshakir reviewed May 14, 2026

View reviewed changes


		## OpenConfig Path and RPC Coverage

		## OpenConfig Path and RPC Coverage

Conversation

marcushines commented May 11, 2026

Uh oh!

gemini-code-assist Bot commented May 11, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

OpenConfigBot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Functional Test Report for #5442 / 1cd8768

Virtual Devices

Hardware Devices

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mihirpitale-googler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

robshakir May 14, 2026

Choose a reason for hiding this comment

Uh oh!

robshakir May 14, 2026

Choose a reason for hiding this comment

Uh oh!

robshakir May 14, 2026

Choose a reason for hiding this comment

Uh oh!

robshakir May 14, 2026

Choose a reason for hiding this comment

Uh oh!

robshakir May 14, 2026

Choose a reason for hiding this comment

Uh oh!

robshakir May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OpenConfigBot commented May 11, 2026 •

edited

Loading

Pull Request Functional Test Report for #5442 / `1cd8768`